Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxBenefitSystem.load_variable() and TaxBenefitSystem.update_variable() are improperly typehinted #327

Open
anth-volk opened this issue Dec 24, 2024 · 0 comments

Comments

@anth-volk
Copy link
Contributor

At least, I think. For example, if instantiating a new tax-benefit system (TBS), then using .update_variable() to load off based on a string (as hinted in -core), the underlying .load_variable() method will throw an error indicating that a str type has no property __name__, even though both methods are hinted to take strings. I believe they're actually meant to take Variable-types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant