Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Reproduce in Python code, when simulating over a state, properly update dataset #2027

Open
anth-volk opened this issue Nov 28, 2024 · 0 comments

Comments

@anth-volk
Copy link
Collaborator

For a select subset of reforms that we run over states (e.g., https://policyengine.org/us/policy?focus=policyOutput.policyBreakdown&reform=66051&region=ny&timePeriod=2025&baseline=2&household=49726), the API processes the reforms by swapping the default cps_2024 dataset for the pooled_3_year_cps_2023 dataset and filtering the dataset down by state. At the moment, the Reproduce in Python code does not reflect that, causing the app to output total values that differ from those of the -us package.

This should be pretty simple - we merely need to update the Microsimulation objects to take dataset='pooled_3_year_cps_2023' as an argument. However, we'll need to determine if we also want to add code to pre-filter these datasets, since not doing so causes an individual run to take just under 5 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant