Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_varying_your_earnings should be refactored #2026

Open
anth-volk opened this issue Nov 27, 2024 · 0 comments
Open

test_varying_your_earnings should be refactored #2026

anth-volk opened this issue Nov 27, 2024 · 0 comments

Comments

@anth-volk
Copy link
Collaborator

The original aim of this test was to prevent a situation where a change to a country package, -core, or -api caused a certain type of bug that occurred whereby either the baseline or the reform situation contained NaN values, thereby causing NaN values when comparing the two, and then returning NaN values that crashed the front-end app. However, I think this test is too heavy, does too many things at once, and should be refactored into a proper integration test. It should also mock the database (something very few of the tests do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant