From de57660391feb611c396ab8362feb8d29f321a83 Mon Sep 17 00:00:00 2001
From: Daniel Brooks <bass_rock@me.com>
Date: Thu, 29 Aug 2024 16:02:48 -0700
Subject: [PATCH] fix(federation): updating the preview federation query (#708)

* fix(resolver): ensuring we pass the right federation query

* fix(braze): disbaling braze 500 alarm
---
 infrastructure/braze-content-proxy/src/main.ts                  | 2 +-
 servers/parser-graphql-wrapper/schema.graphql                   | 2 +-
 .../parser-graphql-wrapper/src/__generated__/resolvers-types.ts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/infrastructure/braze-content-proxy/src/main.ts b/infrastructure/braze-content-proxy/src/main.ts
index 65ae49dea..51f818db5 100644
--- a/infrastructure/braze-content-proxy/src/main.ts
+++ b/infrastructure/braze-content-proxy/src/main.ts
@@ -303,7 +303,7 @@ class BrazeContentProxy extends TerraformStack {
           threshold: 25,
           evaluationPeriods: 4,
           period: 300,
-          actions: config.isDev ? [] : [snsTopic.arn],
+          actions: config.isDev ? [] : [], // Disabling for now since this is not really a valid metric for a low volume service. 1 500 can cause this to alarm
         },
       },
     });
diff --git a/servers/parser-graphql-wrapper/schema.graphql b/servers/parser-graphql-wrapper/schema.graphql
index 8fb79f361..d7cacd419 100644
--- a/servers/parser-graphql-wrapper/schema.graphql
+++ b/servers/parser-graphql-wrapper/schema.graphql
@@ -175,7 +175,7 @@ type Item
   "The client preview/display logic for this url. The requires for each object should be kept in sync with the sub objects requires field."
   preview: PocketMetadata
     @requires(
-      fields: "syndicatedArticle { title excerpt mainImage publishedAt authorNames publisherUrl publisher { logo name } } collection { title excerpt publishedAt authors { name } imageUrl } corpusItem { title excerpt datePublished publisher image { url } }"
+      fields: "syndicatedArticle { title excerpt mainImage publishedAt authorNames publisherUrl publisher { logo name } } collection { title excerpt publishedAt authors { name } imageUrl } corpusItem { title excerpt datePublished publisher image { url } authors { name sortOrder } }"
     )
 
   "If the item is a syndicated article, then the syndication information"
diff --git a/servers/parser-graphql-wrapper/src/__generated__/resolvers-types.ts b/servers/parser-graphql-wrapper/src/__generated__/resolvers-types.ts
index b8de82b73..37f5d4c62 100644
--- a/servers/parser-graphql-wrapper/src/__generated__/resolvers-types.ts
+++ b/servers/parser-graphql-wrapper/src/__generated__/resolvers-types.ts
@@ -988,7 +988,7 @@ export type ItemResolvers<ContextType = IContext, ParentType extends ResolversPa
   mimeType?: Resolver<Maybe<ResolversTypes['String']>, { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>), ContextType>;
   normalUrl?: Resolver<ResolversTypes['String'], { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>), ContextType>;
   originDomainId?: Resolver<Maybe<ResolversTypes['String']>, { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>), ContextType>;
-  preview?: Resolver<Maybe<ResolversTypes['PocketMetadata']>, { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>) & GraphQLRecursivePick<ParentType, {"syndicatedArticle":{"title":true,"excerpt":true,"mainImage":true,"publishedAt":true,"authorNames":true,"publisherUrl":true,"publisher":{"logo":true,"name":true}},"collection":{"title":true,"excerpt":true,"publishedAt":true,"authors":{"name":true},"imageUrl":true},"corpusItem":{"title":true,"excerpt":true,"datePublished":true,"publisher":true,"image":{"url":true}}}>, ContextType>;
+  preview?: Resolver<Maybe<ResolversTypes['PocketMetadata']>, { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>) & GraphQLRecursivePick<ParentType, {"syndicatedArticle":{"title":true,"excerpt":true,"mainImage":true,"publishedAt":true,"authorNames":true,"publisherUrl":true,"publisher":{"logo":true,"name":true}},"collection":{"title":true,"excerpt":true,"publishedAt":true,"authors":{"name":true},"imageUrl":true},"corpusItem":{"title":true,"excerpt":true,"datePublished":true,"publisher":true,"image":{"url":true},"authors":{"name":true,"sortOrder":true}}}>, ContextType>;
   readerSlug?: Resolver<ResolversTypes['String'], { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>), ContextType>;
   resolvedId?: Resolver<Maybe<ResolversTypes['String']>, { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>), ContextType>;
   resolvedNormalUrl?: Resolver<Maybe<ResolversTypes['Url']>, { __typename: 'Item' } & (GraphQLRecursivePick<ParentType, {"givenUrl":true}> | GraphQLRecursivePick<ParentType, {"itemId":true}>), ContextType>;