Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust requests #18

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Robust requests #18

merged 3 commits into from
Sep 18, 2024

Conversation

louonezime
Copy link
Collaborator

@louonezime louonezime commented Sep 18, 2024 •
edited
Loading

Description

Please provide a detailed description of what was done in this PR.
Precise the issue that you are resolving.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functional / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@louonezime louonezime self-assigned this Sep 18, 2024
pierrelissope
pierrelissope reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@pierrelissope pierrelissope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@pierrelissope pierrelissope merged commit 4ec7bf2 into main Sep 18, 2024
1 check passed
This was linked to issues Sep 18, 2024
[Bug]: Crash when there is no / at the end of the url #9
Closed
[Feature]: robust matching for header/body #13
Closed
@louonezime louonezime added bug Something isn't working enhancement New feature or request match labels Sep 18, 2024
@louonezime louonezime deleted the robust-requests branch October 4, 2024 18:42
@louonezime louonezime restored the robust-requests branch October 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrelissope pierrelissope pierrelissope left review comments

Assignees

@louonezime louonezime

Labels
bug Something isn't working enhancement New feature or request match
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: robust matching for header/body [Bug]: Crash when there is no / at the end of the url
2 participants
@louonezime @pierrelissope