Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/21 give the possibility to assign/unassign service to/from product #79

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from
Draft

Feature/21 give the possibility to assign/unassign service to/from product #79

wants to merge 60 commits into from

Conversation

roswerk
Copy link
Contributor

@roswerk roswerk commented Feb 9, 2022 •
edited
Loading

Checklist

  • Changed e2e tests
  • Changed unit tests

Closes #21

@PlanBGmbH/flinkey-web-components

roswerk added 23 commits February 9, 2022 13:02
@roswerk
🍱Added flinkey-product-service-admin-table component file
4fe11a9
@roswerk
🚧 Creates table with fetched data
d82a6c7
@roswerk
🚧 Toggles table columns
8de3258
@roswerk
🚧 Watch for products to be load, and loops over to identify products …
da5313e 
…that have services assigned
@roswerk
🚧 Filters all services with no products and assigns it to unlinkedSer…
07d51da 
…vices
@roswerk
🍱 Added Flinkey Modal file
3ec2f32
@roswerk
🚧 Create assign/un-assign modal
cdb60b8
@roswerk
🍱 Added service-dropdown file
61d4679
@roswerk
🚧 Create dropdown with unlinked services
041844f
@roswerk
🚧 Pass selected-service from dropdown to modal
85676c0
@roswerk
🚧 Set selected-service as value of dropdown and close it
c37fd6b
@roswerk
🚧 Receive selected-service from dropdown and save it in dropdownService
5c76e06
@roswerk
🚧 Added conditional Modal for link/unlink
5407caa
@roswerk
🚧 Added service-dropdown to modal
64a4cab
@roswerk
🚧 Added linking functionality
ac717cf
@roswerk
🚧 Added unlinking functionality
766d5bc
@roswerk
🚧 Added close modal functionality
d13ca03
@roswerk
🚧 Added link-services modal opener
ca45046
@roswerk
🚧 Added unlink-services modal opener
1a4ee8c
@roswerk
🚧 Added event-emitter to update data after link/unlink
62bc2f2
@roswerk
🚧 Added listener to know if new data was linked/unlinked from modal
f9f7c21
@roswerk
🚧 Added condition to re-render the DOM if new data was linked/unlinked
fad091f
@roswerk
🔧 Added Customer-ID to defaultHeader
58cf87c
@roswerk roswerk added the needs-review Pull requests which need code review and approval from flinkey Web Components team. label Feb 9, 2022
@roswerk roswerk requested a review from BHuber-PlanB February 9, 2022 14:03
@BHuber-PlanB BHuber-PlanB added work-in-progress Pull requests which are still being worked on, more changes will follow. and removed needs-review Pull requests which need code review and approval from flinkey Web Components team. labels Feb 9, 2022
@roswerk roswerk marked this pull request as draft February 9, 2022 14:10
BHuber-PlanB
BHuber-PlanB reviewed Feb 10, 2022
View reviewed changes
components/src/utils/utils.ts Outdated
@@ -42,6 +42,7 @@ function setDefaultHeaders(): HeadersInit {
'flinkey-API-Key': Globals.apiKey,
'Content-Type': 'application/json',
'Accept': 'application/json',
'Customer-ID': '1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit such values. This should already be part of Globals class. Please use value from there.

roswerk and others added 30 commits February 10, 2022 14:29
@roswerk
🚧 Fetch unlinkedServices and display them in dropdown
c877402
@roswerk
🚧 Added if check based on if link/unlink has been successful
c31d1f1 
Server responds with undefined if link/unlink has been successful
@roswerk
Merge branch 'main' into feature/21-give-the-possibility-to-assign/un…
ba6471a 
…assign-service-to/from-product
@roswerk
Merge branch 'main' into feature/21-give-the-possibility-to-assign/un…
3ca05b3 
…assign-service-to/from-product
@roswerk
🚧 Changed conditional to display table-columns from state to props
4bbb128
@roswerk
♻️ Improved messages in link/unlink modal
5bbe18f
@BHuber-PlanB
♻️ Improved code of service and product assign component
8e98d02
@BHuber-PlanB
Merge branch 'main' into feature/21-give-the-possibility-to-assign/un…
d079b78 
…assign-service-to/from-product
@BHuber-PlanB
♻️ Made product table easier to maintain
e757e42
@BHuber-PlanB
🔖 Bumped package version
137d2b6
@roswerk
♻️ Refactor dropdown to be reusable
0dc8c4b
@BHuber-PlanB
♻️ added generic table component
f7710cb
@BHuber-PlanB
♻️ integrated generic table in service/product table
e768077
@BHuber-PlanB
🐛 fixed table value parsing
3babd9e
@BHuber-PlanB
🐛 fixed some paths and filter for visibleColumns
7c27f0a
@BHuber-PlanB
🐛 fixed getFieldValue function provided with undefined field
5a92b2c
@BHuber-PlanB
♻️ created generic dropdown component and integrated it into flinkey-…
7044aa3 
…keyfob-catalog.tsx
@BHuber-PlanB
✨ extended table component to support rendering passed template to cell
d1b6a96
@BHuber-PlanB
🚧 added action column cell template for product/service table
4236b43
@BHuber-PlanB
✨ added generic button component
ab3ba44
@BHuber-PlanB
🔥 removed focus border from generic button
85faae5
@BHuber-PlanB
✅ fixed keyfob catalog unit test
17fe258
@BHuber-PlanB
✅ added button unit tests
590df09
@BHuber-PlanB
✅ fixed utils unit tests
ea6fed9
@BHuber-PlanB
♻️ improved event handler name
7b7e449
@BHuber-PlanB
✅ added unit tests for generic button and dropdown
ed02f50
@BHuber-PlanB
✅ added parent describe to unit test files
7488d3f
@BHuber-PlanB
✅ added unit tests for table's getVisibility function
3676b49
@BHuber-PlanB
✅ added unit tests for table's getFieldValue function
7fedd8d
@roswerk
✨ Added generic modal component
c3cbff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BHuber-PlanB BHuber-PlanB BHuber-PlanB left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
work-in-progress Pull requests which are still being worked on, more changes will follow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give the possibility to assign/unassign service to/from product
2 participants
@roswerk @BHuber-PlanB