Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All processing occurs on the main thread #8

Open
pflammertsma opened this issue Aug 12, 2015 · 2 comments
Open

All processing occurs on the main thread #8

pflammertsma opened this issue Aug 12, 2015 · 2 comments

Comments

@pflammertsma
Copy link
Collaborator

No description provided.

@pflammertsma
Copy link
Collaborator Author

Working on a solution in https://github.com/Pixplicity/sharp/tree/thread-safe.

  • Callbacks to load SVGs in a background thread
  • Make invocations of setLayerType() thread-safe
  • Make invocations of into() or intoBackground() thread-safe
  • By default, use background threads when loading SVGs using into() or intoBackground()

pflammertsma pushed a commit that referenced this issue Aug 14, 2015
various changes to allow invocation from background threads for #8
720a5f4 
callback variants of methods: getDrawable() and getSharpPicture()
updated sample
pflammertsma pushed a commit that referenced this issue Aug 14, 2015
various changes to allow invocation of into() and intoBackground() fr…
cee2e4d 
…om background threads for #8
@pflammertsma
Copy link
Collaborator Author

In retrospect, using background threads by default for into() and intoBackground() is perhaps not very wise. There's no facility to opt-out of this behavior, so perhaps it's best that the implementing application takes care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pflammertsma