Extend TestNGToAssertJRules Refaster rule collection
#1483
Conversation
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
sschroevers/more-testng-to-assertj-rules
branch
from
f501c9b to
94bff3e
Compare
|
Looks good. No mutations were possible for these changes. |
|
| @@ -635,6 +818,58 @@ void after(Object[] actual, String message, Object[] expected) { | |||
| } | |||
| } | |||
|
|
|||
| static final class AssertEqualFloatArraysWithDelta { | |||
There was a problem hiding this comment.
I was thinking that maybe we should update the Refaster rule names for the ones that we introduce or tweaked. I can see how we maybe don't want to touch all of those names here right now as well; so I'm also fine with leaving it as is for now.
There was a problem hiding this comment.
Yeah, I'm often torn on this point. Reason I prefer to stick with the naming scheme in this class for now is that (a) it makes it easier to see which rules are still missing (and where to insert them) and (b) we haven't finalized the naming scheme yet, while I expect many edge cases to surface (see e.g. this comment, but I have similar struggles with another set of "migration-style" Refaster rules I'm currently working on).
Suggested commit message:
While working on this I found an issue; filed testng-team/testng#3199.
(Perhaps it's time to move this to an Error Prone check, but given that we don't use TestNG internally anymore, that's likely not worth the trouble. I opened this PR primarily because I had a branch with some of these changes, and decided it was time to "flush" that work.)