Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unnecessary sting concatenation in logging statements; downgrade logging level to INFO in BAU places #370

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ylexus
Copy link

@ylexus ylexus commented Jul 27, 2024

@FDelporte
Copy link
Member

wow, thanks @ylexus, exactly the kind of review the logging needed! looks good af first sight, will dive in a bit deeper one of the next days

Copy link
Member

@eitch eitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, but you changes some of the loggers from warning to info. Please undo that.

@FDelporte
Copy link
Member

Thanks for the cleanup, but you changes some of the loggers from warning to info. Please undo that.

@eitch see ticket #369, some warnings at the start of the Pi4J context could, in my opinion, indeed be changed to info. Others we will need to review.

@ylexus
Copy link
Author

ylexus commented Jul 29, 2024

Yes, those changes to INFO was the whole point of this, the rest is just a side effect (automatic refactoring). Apologies, I should have mentioned the original issue is in the PR title and not in the first comment.

@eitch
Copy link
Member

eitch commented Jul 29, 2024

You mixed two things in the same commit. Can you please change that, then i'll merge your request. Commits should clearly define what they change, which is not the case here

@ylexus
Copy link
Author

ylexus commented Jul 29, 2024

@eitch done

Copy link
Member

@eitch eitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@eitch eitch merged commit 9c4a54a into Pi4J:develop Jul 29, 2024
1 check passed
@ylexus
Copy link
Author

ylexus commented Jul 29, 2024

Thanks, how often do you do releases? Just to know when to expect this change to be released.

@eitch
Copy link
Member

eitch commented Jul 30, 2024

As often as needed. We just did a 2.6.1. We might do a 2.6.2 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants