Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-4.3.4 is unable to change system's color font in "Actions" section #2651

Open
lignuxer983 opened this issue Mar 17, 2023 · 6 comments
Open

Comments

@lignuxer983
Copy link

OS: Kubuntu-22.04
OpenJDK: v-11

Most of the POL-4 fonts are in sync with the system's theme with the exeption of the "Actions" section where it stays black colored and it's hard to read when using dark themes. I tried many different themes and none worked so it must probably be a source code setting that must be fixed. Also, please update the dark gray colored icons for colored png icons. I currently copy/pasted oxygen icons to make it more appealing on dark themes.

POL4-font

@lignuxer983
Copy link
Author

Update:

I fixed all missing background/font colors by tweaking the RGB of files:

  1. mainwindow.py
  2. InstallWindow.py
  3. POL_SetupFrame.py

I don't know much about how GTK works but it would be nice if this issue is fixed, this font color scheme problem has been around for years.

@Braintoe
Copy link

Braintoe commented Aug 20, 2023

@lignuxer983 Thanks for pointing me to those files. In case someone else needs them: the attached ones should work with a dark background.
-edit: attachment deleted, updated version below -

The only thing I am utterly unable to find is the checkbox list that pops up during manual installation, which looks like this on a computer with a dark theme - the font color is taken from the theme but the background seems to be hardcoded somewhere in PlayOnLinux:

image

Does someone know how to change the background color of that window?

@qparis
Copy link
Member

qparis commented Aug 20, 2023

Should be in POL_SetupFrame.py

@Braintoe
Copy link

Braintoe commented Aug 20, 2023

Should be in POL_SetupFrame.py

@qparis thanks a lot, I had failed to see that one!
The attached file makes everything visible on dark themes then:
usr_share_playonlinux_python.zip

Use only with POL 4.3.4!

@qparis
Copy link
Member

qparis commented Aug 22, 2023

Great! Can you send a merge request?

@Braintoe
Copy link

Braintoe commented Sep 1, 2023

Great! Can you send a merge request?

Sorry for the late reply, I had some unexpected issues with my computer -.- Well, that was my first and (for the forseeable future) my last NVMe SSD...

Would a merge request make any sense here? I fear I did not solve the issue universally (I honestly have no clue about Python), I just updated the colours to fit to a dark theme. This does mean however my files will likely cause issues on a light theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants