Reg.: Merge of MTFix and WMP projects?

[Philzen]

From Issue 1:

Hello Philzen,

i think we are developing a solution approach for the same problem in the last days/weeks. What did you think about to merge our projects about the WebView-Android 2.x Issue and work together on a better solution?

Yes. Absolutely. Let's join forces!

see http://code.google.com/p/android/issues/detail?id=11909 and http://fastr.de for more details.

@fastrde you may have overlooked me actually appreciating your solution in the mentioned Google Ticket ... The MTFix javascript implementation is mostly superior in my eyes, however i didn't wan't to be rude to nick it just the same week also given there was a working one at hand ;)

If you'd like commit the code to the git repo (which will also secure your credits for it from that moment on until eternity - or until the last local copy of the repository disappears from the planet), i would love to include (or have you do that so you can get the fame as well as the blame) some parts straightaway. I have some questions on certain details of MTFix as well as exchange ideas and lessons learned, so - hoping to count you in - i would suggest the following tools to manage collaboration:

1. separate questions and tasks for all aspects of merging and improving our two codebases (just like this one)
2. exchange on some more on the details, lessons learned, touch event nitty-gritty etc. on the Wiki, starting with the Architecture Page - please feel free to correct or amend anything you see wrong or missing.

[fastrde]

Hello again,
i was not at home last weekend so my answer is a litte late.
First, I like the solution to inject the javascript from the java-class so you don't have to patch the web application. But we should release the javascript sourcecode in an uncompressed version too(found the uncompressed version in assets)
I cloned your git master localy and i tried to merge my javascript into it.
While i tried this i noticed, that we have to discuss what parts we use from WMP and MTfix.
Did you have an instant messanger? (jabber?) can you write me an email so we can communicate faster? ([email protected])

byebye

fastrde

[Philzen]

@fastrde Would be great if you could commit the MTfix.js file into the /libs folder (you may push directly w/o a pull request)

I would then incorporate the event class (the one with the _send() method) from it in order to make the current js code more DRY ;)

[fastrde]

Hi Philzen,

i pushed the javascript files.
The ...without_XYRatio.js don't use the x/y multiplikator that i implemented to fix an early "touch event not where i touched" issue on my device.
I've pushed both files to look if the approach with the multiplikator (set from the device or automatically calculated) can fix the issue with the device.ratio (Issue #16) if it not already fixed.

[Philzen]

Hi fastrde,

thx so much for those - as i could replicate the "touches are off" behaviour and it indeed seems fixed by respecting window.devicePixelRatio in the new 0.3 release, i'll combine that with the MTFix Touch Object.

Note: i just had to rewrite the repository history with https://help.github.com/articles/changing-author-info, which gladly worked w/o a problem. Anyway - pls ensure your git name and/or eMail-Adress match those of your github account for your wmp repository settings.

Cheers!