Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CID_NUM value in SCCPLINE issue #72

Open
justinkoby opened this issue Apr 23, 2020 · 2 comments
Open

CID_NUM value in SCCPLINE issue #72

justinkoby opened this issue Apr 23, 2020 · 2 comments

Comments

@justinkoby
Copy link

I noticed an issue when I was setting Outbound CID for my SCCP devices. I found that their Outbound CID was then displaying as their CID for internal calls as well (instead of their extension nunber).

I opened an issue request over at chan-sccp (chan-sccp/chan-sccp#516) while I continued to do research.

I discovered today that the CID_NUM value in the SCCPLINE table appears to be populating with the wrong CID value. When I manually change the CID_NUM to the correct extension number, it appears to solve the issue.

However, as soon as I make a change to the extension through the extension GUI, the line in the SCCPLINE table for that extension is deleted and recreated with the outbound CID as the CID_NUM value instead of the extension number.

Is this something that is a misconfiguration on my part or an issue with code somewhere? I've looked through the code here but have not found a "insert into sccpline...." SQL statement.
@dkgroot
Copy link
Contributor

dkgroot commented Apr 23, 2020

Please read: to explain the issue further.
please check my comment as well.

@dkgroot
Copy link
Contributor

dkgroot commented Nov 8, 2020

@PhantomVl Can you help me out to correct this. I cannot find where the outboundcid is being saved into the sccpline table. The outboundcid (containting: '"name" ') should be split to fill the two cid_name and cid_num fields, instead of copying everything into cid_num. That way the FPBX dialplan can match the cid_num correctly later on.

@dkgroot dkgroot mentioned this issue Nov 9, 2020
Closed
dkgroot added a commit to dkgroot/sccp_manager that referenced this issue Nov 9, 2020
@dkgroot
parse outboundcid content into cid_num and cid_name sccpline fields
14c3aba 
If outboundcid contains '"name" <num>' the content needs to be split to cid_name and cid_num.
If not the content should be a number and should be copied to cid_num only, in that case we fill cid_name with the value of $label

Fixes: PhantomVl#72

Signed-off-by: Diederik de Groot <[email protected]>
dkgroot referenced this issue in chan-sccp/sccp_manager Apr 2, 2021
@dkgroot
parse outboundcid content into cid_num and cid_name sccpline fields
8e12f70 
If outboundcid contains '"name" <num>' the content needs to be split to cid_name and cid_num.
If not the content should be a number and should be copied to cid_num only, in that case we fill cid_name with the value of $label

Fixes: #72

Signed-off-by: Diederik de Groot <[email protected]>
dkgroot referenced this issue in chan-sccp/sccp_manager Apr 2, 2021
@dkgroot
parse outboundcid content into cid_num and cid_name sccpline fields
07be691 
If outboundcid contains '"name" <num>' the content needs to be split to cid_name and cid_num.
If not the content should be a number and should be copied to cid_num only, in that case we fill cid_name with the value of $label

Fixes: #72

Signed-off-by: Diederik de Groot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dkgroot @justinkoby