Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source of the XMP data is our MP data, should be the original XMP when present #13

Open
PetrVys opened this issue Oct 31, 2024 · 0 comments
Assignees

Comments

@PetrVys
Copy link
Owner

PetrVys commented Oct 31, 2024

The way the program approaches merging XMP is that it creates full XMP data for MotionPhoto and then tries to copy relevant tags and elements from the original image file into it if possible.

Unfortunately this sometimes creates issues, most often with namespace aliases.

When the source image has XMP, the order should be switched around. This requires sanitizing the output of exiftool's XMP - sometimes it contains binary garbage after the end of XML.

We should take only data between <x:xmpmeta and </x:xmpmeta> and create relevant attributes and filled Directory structure inside.

@PetrVys PetrVys self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant