Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login: Identify which ID's to add in Umbraco Core to ease finding some elements #2

Open
PeteDuncanson opened this issue Jun 26, 2018 · 0 comments

Comments

@PeteDuncanson
Copy link
Owner

PeteDuncanson commented Jun 26, 2018

Suggest we try to get a PR in with a bunch of ids added to elements we want to easily get to. The templates in Umbraco Core were never written with testing in mind just "to get the job done" so adding some hooks in that we can latch onto would be super handy. Should be a quick win.

Only issue I can see is that we might get some name clashes if not careful. Might be worth name spacing the ids as a result, something like "login_forgottenEmailLink". Or something like that.

Elements I'm struggling with so far include the error messages (there are three of them), forgotten password form and link that shows it.

@PeteDuncanson PeteDuncanson changed the title Login: Finding error messages is a complete pain, some ids would go a long way. Login: Identify which ID's to add in Umbraco Core to ease finding some elements Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant