Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour for login when already logged in is poor #60

Open
SysPete opened this issue Oct 27, 2016 · 0 comments
Open

Behaviour for login when already logged in is poor #60

SysPete opened this issue Oct 27, 2016 · 0 comments

Comments

@SysPete
Copy link
Member

SysPete commented Oct 27, 2016

Code here in post /login route:

if ( $plugin->logged_in_user ) {
$app->redirect( $app->request->params->{return_url}
|| $plugin->user_home_page );
}

    if ( $plugin->logged_in_user ) {
        $app->redirect( $app->request->params->{return_url}
              || $plugin->user_home_page );
    }

So if user1 is logged and then user2 tries to login then user1 stays logged in and user gets redirected. I think we should produce some kind of error at the least.

SysPete added a commit that referenced this issue Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant