2015 hackathon misc optimization 2024 rebase #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 1 million tests processed, NYTProf shows this sub was called once for each test processed, but the print block only executed 1600 times. So dont compute the output method name, and dont fetch the current test number, if we aren't going to use it.
… behavior between runs" This partially reverts commit 4d4d3f0. In "Unknown arguments to TAP::Harness::new" croak, sorting was kept, but moved into the branch where it is needed.
new() went from 17.2 seconds (/1000000) exclusive time nytprof to 12.2 seconds after this commit.
Also combine subs with identical bodies. On Win32, memory usage sampled with "perl -MTAP::Parser::Iterator -E"system 'pause'" caused memory usage to drop from 2,688KB to 2,672KB after this commit for me. next() dropped from 68us inclusive to 44us with nytprof, for comparison next_raw is 39us. next() is called once per test so it is hot. # Conflicts: # t/compat/test-harness-compat.t
If something is very wrong with the TAP stream, don't silence $@ die errors.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 2024 rebase of the 2016 code in #52
All the not Win32 specific optimization patches are in this PR now. This decouples the Win32 parallel IO feature/PR from these performance patches. The issues were found with nytprof and step debugging high hit count parts of T::H.