prove no longer supports --verbose when running tests in parallel

[avar]

This is related to #85 and #101 but it's a more general issue.

Regression with using ::Env

First, there's a regression in a8fb517 (Make prove respect environmental variables #28, 2013-10-27), when we started paying attention to HARNESS_OPTIONS in prove having the options set to jN where N > 1 suppresses the --verbose output completely. E.g. (running this on the git.git test suite):

HARNESS_OPTIONS=j2 perl -I ~/g/Test-Harness/lib ~/g/Test-Harness/bin/prove --verbose t0002-gitfile.sh :: -
-verbose

ok 1 - initial setup
ok 2 - bad setup: invalid .git file format
ok 3 - bad setup: invalid .git file path
ok 4 - final setup + check rev-parse --git-dir
[...]

But before a8fb517 it would show the verbose output, curiously if you pipe it to | cat it shows up, so there's some isatty() check somewhere.

Instead it should at the very least be smart enough to figure out that your -jN setting doesn't matter in the case of a single test.

The --verbose output doesn't make much sense under -jN

When you run N tests at a time it will struggle with some ASCII-art to represent the concurrency, and then dump the non-verbose output (under --verbose !) for whatever test it happened to run last:

$ HARNESS_OPTIONS= perl -I ~/g/Test-Harness/lib ~/g/Test-Harness/bin/prove --shuffle -j8 --verbose t000*
.sh :: --verbose
===(       1;0  0/?  1/?  0/?  0/?  0/?  0/?  0/?  0/? )================ok
===(       5;0  0/?  1/?  0/?  0/?  0/?  0/?  0/?  0/? )================ok
===(      11;0  0/?  1/?  0/?  0/?  0/?  0/?  0/?  0/? )================ok
===(      29;0  0/?  0/?  0/?  10/?  3/?  0/?  1/? )====================ok
===(      34;0  0/?  0/?  0/?  11/?  3/?  0/? )=========================ok
===(      83;0  19/?  11/?  0/?  18/?  1/? )============================ok
===(     180;0  55/?  29/?  0/?  36/? )=================================ok
===(     262;1  61/?  9/?  49/? )=======================================ok
===(     497;4  266/?  28/? )===========================================ok
t0008-ignores.sh ..... 
ok 343 - beyond a symlink from subdirectory with --verbose
ok 344 - beyond a symlink from subdirectory with --verbose -n
ok 345 - beyond a symlink from subdirectory with --verbose --non-matching
ok 346 - submodule
ok 347 - submodule with -q
[...]

There's a lot more than the "ok" output under --verbose in that test, so the verbose output is being stripped. This is another case where piping it to | cat gives expected results.

Patch?

Not submitting this as a PR since I'm not familiar with the code, but this seems to fix the above issues:

diff --git a/lib/TAP/Harness.pm b/lib/TAP/Harness.pm
index a9a865d..105f846 100644
--- a/lib/TAP/Harness.pm
+++ b/lib/TAP/Harness.pm
@@ -453,6 +453,8 @@ Any keys for which the value is C<undef> will be ignored.
 
         local $default_class{formatter_class} = 'TAP::Formatter::File'
           unless -t ( $arg_for{stdout} || \*STDOUT ) && !$ENV{HARNESS_NOTTY};
+        local $default_class{formatter_class} = 'TAP::Formatter::File'
+          if $self->jobs > 1 && $arg_for{verbosity};
 
         while ( my ( $attr, $class ) = each %default_class ) {
             $self->$attr( $self->$attr() || $class );

[Leont]

Yeah, this sounds logical.