Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]- v2.5.x - Fader Up/Down controls cause errors when attempt to goto level outside valid range #106

Open
cdenig opened this issue Apr 22, 2024 · 2 comments · May be fixed by #109
Open
Assignees
Labels
bug Something isn't working

Comments

@cdenig
Copy link
Contributor

cdenig commented Apr 22, 2024

Describe the bug
Fader Up/Down controls attempt to set Level to value outside maximum/minimum range. and cause invalid parameter errors.

Stacktrace
Include a stack trace of the exception if possible.

[dsp01-ssh] Received: '"A_VTCRX_VOL" increment level 2 2.0[0D][0A]
-ERR INVALID_PARAMETER Value out of range: attr:level min:-45 max:3 val:5 -ERR INVALID_PARAMETER[0D][0A]'

To Reproduce
Steps to reproduce the behavior:

  1. Assuming stepsize set to 2dB, lower fader to within 2dB of minimum value (or raise fader fader within 2dB of maximum value)
  2. Click on Down (or Up) button
  3. See error in Biamp response of value does not change. Also results in a fader bar not able to goto 0% or 100%.

Expected behavior
Up/Down Buttons check if current level is within stepsize and if yes, then send the min or max value on button press.

Screenshots
na

Additional context
na

@cdenig cdenig added the bug Something isn't working label Apr 22, 2024
@cdenig cdenig self-assigned this Apr 23, 2024
@cdenig
Copy link
Contributor Author

cdenig commented Apr 23, 2024

Added logic to prevent sending Volume[Up,Down] commands that would cause fader to move outside valid minMax range.

Added feat so slider will automatically go to [Min,Max]Level if user level request is within IncrementAmount of desired level.

Commit: 3a5b45b

@cdenig cdenig linked a pull request Jun 3, 2024 that will close this issue
@cdenig
Copy link
Contributor Author

cdenig commented Jun 3, 2024

#109 PR submitted. Issue can close on approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant