From fa293a42fa800956f0cb9d64487624d3ac3ec58e Mon Sep 17 00:00:00 2001 From: Raul Torres Date: Mon, 6 Jan 2025 15:36:50 -0500 Subject: [PATCH] [NFC] Fix typos and phrasing --- frontend/catalyst/debug/compiler_functions.py | 4 ++-- frontend/test/lit/test_mlir_plugin.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/catalyst/debug/compiler_functions.py b/frontend/catalyst/debug/compiler_functions.py index 2fa16b4218..7dc1a17756 100644 --- a/frontend/catalyst/debug/compiler_functions.py +++ b/frontend/catalyst/debug/compiler_functions.py @@ -42,7 +42,7 @@ def get_compilation_stage(fn, stage): All the available stages are: - - MILR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, + - MLIR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, and ``MLIRToLLVMDialect``. - LLVM: ``llvm_ir``, ``CoroOpt``, ``O2Opt``, ``Enzyme``, and ``last``. @@ -139,7 +139,7 @@ def replace_ir(fn, stage, new_ir): Available stages include: - - MILR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, + - MLIR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, and ``MLIRToLLVMDialect``. - LLVM: ``llvm_ir``, ``CoroOpt``, ``O2Opt``, ``Enzyme``, and ``last``. diff --git a/frontend/test/lit/test_mlir_plugin.py b/frontend/test/lit/test_mlir_plugin.py index 39b0c58e04..44a0d4f488 100644 --- a/frontend/test/lit/test_mlir_plugin.py +++ b/frontend/test/lit/test_mlir_plugin.py @@ -15,14 +15,14 @@ # RUN: %PYTHON %s | FileCheck %s """ -This test makes sure that we can use plugins from the compiler +This test makes sure that we can use plugins from the compiler. Given the standalone-plugin in the MLIR repository, can we verify that it works when loading it from python? This test uses a lot of machinery that is not exposed to the user. However, testing the standalone-plugin (as written in the LLVM repository) -is impractical. The standalone-plugin rewrites a symbols with the name +is impractical. The standalone-plugin rewrites all symbols with the name `bar` to symbols with the name `foo`. However, since the standalone plugin is meant to be more of an example, it does not modify the uses of symbol `bar` and change them to `foo`. @@ -50,7 +50,7 @@ def module(): print(module.mlir) ``` -It would succeed in generate correct MLIR during the lowering from JAXPR to MLIR. +It would succeed at generating correct MLIR during the lowering from JAXPR to MLIR. However, after the `standalone-switch-bar-foo` pass, the verifier would fail because it would see callsites to `@bar` but no definitions for `@bar`.