From 1c0935b02a00fd006d2afeb295fe4859735446d3 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 7 Jan 2025 09:44:56 -0500 Subject: [PATCH] Daily rc sync to main (#1418) Automatic sync from the release candidate to main during a feature freeze. --------- Co-authored-by: erick-xanadu <110487834+erick-xanadu@users.noreply.github.com> Co-authored-by: Raul Torres <138264735+rauletorresc@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <> Co-authored-by: Joey Carter --- doc/index.rst | 6 +++--- frontend/catalyst/debug/compiler_functions.py | 4 ++-- frontend/test/lit/test_mlir_plugin.py | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/index.rst b/doc/index.rst index d5c8ab7f9f..879fa14bb0 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -54,11 +54,11 @@ Catalyst .. mdinclude:: ../README.md :start-line: 20 - :end-line: 73 + :end-line: 72 .. mdinclude:: ../README.md - :start-line: 142 - :end-line: 163 + :start-line: 134 + :end-line: 155 .. toctree:: :maxdepth: 2 diff --git a/frontend/catalyst/debug/compiler_functions.py b/frontend/catalyst/debug/compiler_functions.py index 2fa16b4218..7dc1a17756 100644 --- a/frontend/catalyst/debug/compiler_functions.py +++ b/frontend/catalyst/debug/compiler_functions.py @@ -42,7 +42,7 @@ def get_compilation_stage(fn, stage): All the available stages are: - - MILR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, + - MLIR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, and ``MLIRToLLVMDialect``. - LLVM: ``llvm_ir``, ``CoroOpt``, ``O2Opt``, ``Enzyme``, and ``last``. @@ -139,7 +139,7 @@ def replace_ir(fn, stage, new_ir): Available stages include: - - MILR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, + - MLIR: ``mlir``, ``HLOLoweringPass``, ``QuantumCompilationPass``, ``BufferizationPass``, and ``MLIRToLLVMDialect``. - LLVM: ``llvm_ir``, ``CoroOpt``, ``O2Opt``, ``Enzyme``, and ``last``. diff --git a/frontend/test/lit/test_mlir_plugin.py b/frontend/test/lit/test_mlir_plugin.py index 39b0c58e04..44a0d4f488 100644 --- a/frontend/test/lit/test_mlir_plugin.py +++ b/frontend/test/lit/test_mlir_plugin.py @@ -15,14 +15,14 @@ # RUN: %PYTHON %s | FileCheck %s """ -This test makes sure that we can use plugins from the compiler +This test makes sure that we can use plugins from the compiler. Given the standalone-plugin in the MLIR repository, can we verify that it works when loading it from python? This test uses a lot of machinery that is not exposed to the user. However, testing the standalone-plugin (as written in the LLVM repository) -is impractical. The standalone-plugin rewrites a symbols with the name +is impractical. The standalone-plugin rewrites all symbols with the name `bar` to symbols with the name `foo`. However, since the standalone plugin is meant to be more of an example, it does not modify the uses of symbol `bar` and change them to `foo`. @@ -50,7 +50,7 @@ def module(): print(module.mlir) ``` -It would succeed in generate correct MLIR during the lowering from JAXPR to MLIR. +It would succeed at generating correct MLIR during the lowering from JAXPR to MLIR. However, after the `standalone-switch-bar-foo` pass, the verifier would fail because it would see callsites to `@bar` but no definitions for `@bar`.