[ENH] Better names for the anatomical status variables

[mattcieslak]

          Someday we should change this to acpc or anat. Not urgent though

Originally posted by @mattcieslak in #154 (comment)

[tsalo]

Basically everything with "t1w" or "t2w" can be changed to "anat".

[mattcieslak]

should it be anat or acpc?

[tsalo]

I thought we were referencing the modality, not the space. If it's about the space then acpc makes more sense.

[mattcieslak]

In this case (for the transforms) the space is the most important part. the transform could have been computed via a t1w or t2w, but either would be applicable for this transform.

The only case in qsirecon where we might need to know the contrast of the acpc hi-res reference image is if we're registering a freesurfer image to it. Even then we'd still use Mattes as the metric so I'm not sure how the actual modality would change anything

[tsalo]

The two variables we would change are has_qsiprep_t1w and has_qsiprep_t1w_transforms. My understanding of this issue is that the variables are contrast-specific but shouldn't be. However, it looks like has_qsiprep_t1w_transforms is concerned with the template-to-ACPC and ACPC-to-template transforms (i.e., it only cares about the ACPC space and not the original anatomical spaces), so has_qsiprep_acpc_transforms sounds most appropriate. Or even better, maybe has_template_transforms. The other one, has_qsiprep_t1w, is referring to the preprocessed anatomical image, so what we care about is the contrast and not the space. I'd recommend changing it to has_qsiprep_anat to make it contrast-independent.

[mattcieslak]

I'm sold on those new names. Perfectly clear