Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply command can't apply changes because shell script can't be found where expected #341

Open
gabridele opened this issue Dec 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@gabridele
Copy link

Summary

Following the Example Walkthrough, within the apply command, which creates a shell script that applies the changes indicated by the user, I noticed that this shell script wasn't successfully executed because it wasn't being found. The machine expects the shell script to be located within the BIDS directory; instead, it gets saved into the current working directory, namely one folder up than expected.

Additional details

  • CuBIDS version: 1.1.1 (git cloned latest version as of November 25th)
  • Datalad version: 1.1.4

What were you trying to do?

I was trying to run the apply function that is supposed to execute a shell script that creates based on the user input

What did you expect to happen?

I was expecting the command to run the shell script it created to remove certain scans.

What actually happened?

The machine raises an error claiming it didn't find any shell script. This might be because the file got saved one folder up than expected

Reproducing the bug

4
@gabridele gabridele added the bug Something isn't working label Dec 15, 2024
@tsalo tsalo changed the title apply command can't apply changes because shell script can't be found where expected apply command can't apply changes because shell script can't be found where expected Dec 16, 2024
@tientong98
Copy link
Contributor

Hi @gabridele, thank you very much for reporting the bug! Do you by chance have time to work on a pull request for this? If not, no worries, I can work on it. Thanks again!

@gabridele
Copy link
Author

gabridele commented Dec 20, 2024

Hi @tientong98, yes! I actually came up with solutions for all the issues I raised recently. I'm planning to test them out before submitting a PR

@tientong98
Copy link
Contributor

That's perfect! Thank you, @gabridele!! I really appreciate that. You probably know this already, but I recently merged 2 PRs, so please pull the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants