Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in readme local dev part #2428

Closed
nirnayroy opened this issue Jan 12, 2025 · 0 comments · Fixed by #2427
Closed

Typo in readme local dev part #2428

nirnayroy opened this issue Jan 12, 2025 · 0 comments · Fixed by #2427

Comments

@nirnayroy
Copy link
Contributor

nirnayroy commented Jan 12, 2025

The command
bash ./generate-protos.sh
for local development errors out due to no file present. Assuming it meant
bash ./generate_protos.sh

Since the other other files have underscores and not dashes. I think the filename needs to be changed and not the readme. Since the change is trivially small, have opened a PR in case it helps the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant