Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROP MIRROR during Initial Load: Dangling connections on source #2162

Closed
saisrirampur opened this issue Oct 18, 2024 · 2 comments · Fixed by #2258
Closed

DROP MIRROR during Initial Load: Dangling connections on source #2162

saisrirampur opened this issue Oct 18, 2024 · 2 comments · Fixed by #2258
Assignees
@serprex
Labels
bug Something isn't working

Comments

@saisrirampur
Copy link
Contributor

When a mirror is dropped during the initial load process, PeerDB may leave behind dangling connections on the source database. Specifically, the CREATE_REPLICATION_SLOT connection often remains in an idle in transaction state. If left unaddressed, these connections can block vacuuming operations on the source database, which can be risky.
@saisrirampur saisrirampur added the bug Something isn't working label Oct 18, 2024
@serprex
Copy link
Contributor

serprex commented Oct 22, 2024

I assume these are long running dangling connections. The code as is allows for that connection to dangle for a minute before being closed

@serprex
Copy link
Contributor

serprex commented Oct 22, 2024

Implemented #2168 while investigating this issue

@heavycrystal heavycrystal mentioned this issue Nov 14, 2024
Merged
heavycrystal added a commit that referenced this issue Nov 15, 2024
@heavycrystal
use disconnected ctx to ensure snapshot connection drops (#2258)
593093e 
Temporal has a thing for everything

may close #2162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serprex serprex

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use disconnected ctx to ensure snapshot connection drops PeerDB-io/peerdb
2 participants
@serprex @saisrirampur