-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split mpkeys.cpp and mpkeys_test.cpp #336
Comments
@MitchellCash we were talking about removing unclaimed keys from the main file and then since very few of the test keys have been given to people we could reduce that file as well. @ligerzero459 I discussed this with @xmk3 at one point but you'd be better to ask I think. Is it possible to regenerate the mpkeys.cpp file without the unclaimed microprime keys? |
It's possible, but time-consuming. I'll have to go through my communications and figure out who was given keys after the ZC cut-off. |
@ligerzero459 would be totally awesome, @xmk3 certainly seemed convinced it was doable lol |
If that is possible, it has my vote for my favourite option (assuming enough keys are actually removed from mpkeys.cpp that it allows Travis and clang to be friendly). And yes I figure mpkeys_test.cpp is an easy fix as there are way more keys than testers :P Also on a separate note should mpkeys_test.cpp also be moved to our tests sub-directory? |
@MitchellCash being that it's not a unit test, no it should not be placed in the test sub-dir. |
Right |
@IngCr3at1on D'oh I should have thought before typing my question. I completely understand why mpkeys_test.cpp is where it is and not in the tests sub-directory. Maybe I was having a bad day haha |
@ligerzero459 did anyone ever decide if it was possible to remove the unclaimed keys or should we just look into splitting these up to be more compiler friendly? |
Already discussed with @IngCr3at1on prior to deploying Travis but clang has some annoying memory issues and on machines with not much memory (AKA Travis CI) it won't compile Paycoin as it stalls when it gets to mpkeys.cpp and mpkeys_test.cpp due to how many addresses are being written to MicroPrimeDB.
In testing if we split the mpkeys.cpp and mpkeys_test.cpp files we avoid running into this problem.
There could be other solutions but if not the aforementioned should work.
This solves the issue of any users trying to compile with clang on machines with low memory (and when I say low memory it's actually more than you would think it's not like I'm not trying to compile on an RPi) plus allows us to get another compiler in Travis.
The text was updated successfully, but these errors were encountered: