Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onSuccess doesn't fire when the payment has both an input and output w/ the same address (same wallet) #301

Open
Klakurka opened this issue Jan 2, 2024 · 1 comment
Open

onSuccess doesn't fire when the payment has both an input and output w/ the same address (same wallet) #301

Klakurka opened this issue Jan 2, 2024 · 1 comment
Assignees
@chedieck
Labels
bug Something isn't working
Milestone
Phase 3

Comments

@Klakurka
Copy link
Member

Klakurka commented Jan 2, 2024

No description provided.

@Klakurka Klakurka added the bug Something isn't working label Jan 2, 2024
@Klakurka Klakurka added this to the Phase 3 milestone Jan 2, 2024
@Klakurka Klakurka modified the milestones: Phase 3, Phase 4 Jan 25, 2024
@Klakurka Klakurka modified the milestones: Phase 4, Phase 3 Jan 11, 2025
@Klakurka
Copy link
Member Author

My idea, which actually matches what Electrum does, is to treat it as normal on the button side (eg. it would trigger the payment success toast + sound + callbacks), but then in their account they'll see something like "Payment to Self" for 0 XEC (minus tx fee).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chedieck chedieck

Labels
bug Something isn't working
Projects
None yet
Milestone
Phase 3
Development

No branches or pull requests
2 participants
@Klakurka @chedieck