Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize large tcp writes using multiple ethernet frames. #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/EthernetClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,22 @@ size_t EthernetClient::write(uint8_t b)
size_t EthernetClient::write(const uint8_t *buf, size_t size)
{
if (sockindex >= MAX_SOCK_NUM) return 0;
if (Ethernet.socketSend(sockindex, buf, size)) return size;
setWriteError();
return 0;

// keep sending frames until all of the data is sent over the wire
size_t numBytesWritten = 0;
while (size != 0) {
uint16_t numBytesSent = Ethernet.socketSend(sockindex, buf, size);
if (numBytesSent == 0) {
setWriteError();
break;
}
// prepare for the next frame
size -= numBytesSent;
buf += numBytesSent;
numBytesWritten += numBytesSent;
}

return numBytesWritten;
}

int EthernetClient::available()
Expand Down