Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement skin changer functionalities for Online Mode #9

Closed
PauMAVA opened this issue Feb 1, 2020 · 4 comments
Closed

Implement skin changer functionalities for Online Mode #9

PauMAVA opened this issue Feb 1, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@PauMAVA
Copy link
Owner

PauMAVA commented Feb 1, 2020

A proxy based Mojang API is needed to finish this feature

@PauMAVA PauMAVA added enhancement New feature or request help wanted Extra attention is needed labels Feb 1, 2020
@PauMAVA PauMAVA self-assigned this Feb 1, 2020
@andyvonde
Copy link

Yes, u need to implement that. And in offline mode too

@PauMAVA
Copy link
Owner Author

PauMAVA commented Mar 27, 2020

Mojang API implemented.

The feature will be introduced in the next release.

@PauMAVA
Copy link
Owner Author

PauMAVA commented May 5, 2020

The skin-changer is working correctly. The plugin is now broken due to player name changes on player disguising. Must replace all player name comparison checks by UUID checks. Opening #30 to track this issue.

Note that Offline Mode could have some issues with this feature as UUIDs might change on player's rejoin. Will add configuration on the next commit.

PauMAVA added a commit that referenced this issue May 5, 2020
@PauMAVA
Copy link
Owner Author

PauMAVA commented May 5, 2020

Default config:

# If this feature is enabled all players will be randomly disguised with other participant's skin and names periodically
rotate_skins:
  enabled: true
  period: 2 # The period in episodes when a skin rotations cycle will be executed

Issue resolved.

@PauMAVA PauMAVA closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants