Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Upload button #2

Open
fulv opened this issue Dec 17, 2014 · 9 comments
Open

Hide Upload button #2

fulv opened this issue Dec 17, 2014 · 9 comments

Comments

@fulv
Copy link
Contributor

fulv commented Dec 17, 2014

Currently the Upload button appears all the time, which is not right.

fulv added a commit that referenced this issue Dec 17, 2014
Hide controls (Issue #2, refs #207)
@fulv
Copy link
Contributor Author

fulv commented Dec 17, 2014

@cornae, could you please try the demo and let me know if it does what you need?
go to pat-upload repository
git pull
make designerhappy
Go to http://localhost:4001/demo/ to see the demo

@cornae
Copy link
Member

cornae commented Dec 22, 2014

The demo runs with the make file. This is already good news. Also good news is that one of the 3 things I needed works also: The upload button only appears after dragging something on the component. Dit you already fix that or is there a version issue with the one in PI?

The 2 remaining things:

  • A property label:. With which I may influence the text that currently reads 'Drop files here...', defaulting to 'Drop files here…' (But then with a real ellipsis instead of three dots)
  • A property trigger:. With which I may influence what triggers the upload. Defaulting to value button which leaves the current behaviour unchanged. A value auto would always hide the upload button and start uploading automatically after the user drags something on.

Op 17 dec. 2014, om 15:37 heeft Fulvio Casali [email protected] het volgende geschreven:

@cornae https://github.com/cornae, could you please try the demo and let me know if it does what you need?
go to pat-upload repository
git pull
make designerhappy
Go to http://localhost:4001/demo/ to see the demo


Reply to this email directly or view it on GitHub #2 (comment).

@fulv
Copy link
Contributor Author

fulv commented Dec 23, 2014

Yes, @cornae, it was my fix that makes the upload button only appear after dragging something on the component.

@fulv
Copy link
Contributor Author

fulv commented Dec 24, 2014

I have added a label property.

@cornae
Copy link
Member

cornae commented Dec 24, 2014

Fab.

Op 23 dec. 2014, om 12:52 heeft Fulvio Casali [email protected] het volgende geschreven:

Yes, @cornae, it was my fix that makes the upload button only appear after dragging something on the component.


Reply to this email directly or view it on GitHub.

@cornae
Copy link
Member

cornae commented Dec 24, 2014

Label property works great. I've tweaked only a few triple dots to ellipses and the content of the default line.

What about the trigger property?

fulv added a commit that referenced this issue Dec 25, 2014
@fulv
Copy link
Contributor Author

fulv commented Dec 25, 2014

I added the trigger property.
Merry Christmas!

@cornae
Copy link
Member

cornae commented Dec 25, 2014

Great! Is this all available also in the PI proto already? Buon Natale anche a te! :)

Op 25 dec. 2014 om 09:20 heeft Fulvio Casali [email protected] het volgende geschreven:

I added the trigger property.
Merry Christmas!


Reply to this email directly or view it on GitHub.

@fulv
Copy link
Contributor Author

fulv commented Dec 26, 2014

I still don't know exactly how the updating of patterns into PloneIntranet happens. I'll try later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants