Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rect glyph #84

Open
fleimgruber opened this issue Sep 29, 2020 · 3 comments
Open

Support rect glyph #84

fleimgruber opened this issue Sep 29, 2020 · 3 comments

Comments

@fleimgruber
Copy link

Trying to do e.g. df.plot(kind="rect", ...) results in ValueError: Allowed plot kinds are 'line', 'step', 'point', 'scatter', 'bar', 'barh', 'hist', 'area', 'pie', 'map'.

Do you plan to support the rect glyph? Is there a specific reason it is not yet supported? How much effort would you estimate for that? With some guidance I might tackle it myself.

@PatrikHlobil
Copy link
Owner

Hi @fleimgruber ,

contributions are always welcome. How would such an API for an "rect"-plot look like. How should a dataframe be formed and how should the plot look like?

Best,

Patrik

@fleimgruber
Copy link
Author

fleimgruber commented Oct 1, 2020

How would such an API for an "rect"-plot look like. How should a dataframe be formed and how should the plot look like?

See the API reference and also this example.

contributions are always welcome.

I will have a look into the code then and try to come up with a PR.

@PatrikHlobil
Copy link
Owner

Ah, got it. You want to implement something like a matrix plot. I actually wanted to implement this a long time ago but didn’t find the time to do so.

If you need any advice, please ask me.

Best Patrik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants