Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SKIP_PREFLIGHT_CHECK=true from ui/.env #135

Open
Powersource opened this issue Nov 4, 2020 · 1 comment
Open

Remove SKIP_PREFLIGHT_CHECK=true from ui/.env #135

Powersource opened this issue Nov 4, 2020 · 1 comment
Labels
Priority: 3 (later)

Comments

@Powersource
Copy link
Member

We added it here #134 since my eslint addon in vscode only seemed to work with eslint@7, and react-scripts start complains and won't let you build if you're not using the same version as them which is eslint@6. That feels pretty silly since you don't need eslint for actually building the app, therefore I added SKIP_PREFLIGHT_CHECK=true which disables the check from react-scripts. We should try removing that in the future though, since it might make other breaking package installations slip by.
@Powersource
Copy link
Member Author

lol wtf github

@Powersource Powersource reopened this Jan 6, 2021
@aerugo aerugo added test and removed test labels Feb 8, 2021
@aerugo aerugo assigned aerugo and unassigned aerugo Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 3 (later)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Powersource @aerugo