Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Updating the service worker after a release might fail #10602

Open
Dschoordsch opened this issue Dec 13, 2024 · 0 comments
Open

Bug: Updating the service worker after a release might fail #10602

Dschoordsch opened this issue Dec 13, 2024 · 0 comments
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@Dschoordsch
Copy link
Contributor

I ran into an issue with Safari during an update. The service worker was 2 releases behind and could not load any source files. The production build is overwriting old versions, for example:

'url': 'https://action-files.parabol.co/production/build/no_entry_a9bd1d42811914b6f10b.svg'

Updating the service worker though is triggered by either useTrebuchetEvents or useServiceWorkerUpdater. These files might not be available in the browser and the current service worker cannot retrieve those. As a workaround the client might need to clear their site data.

There are a couple of possible solutions:

  • store multiple versions of production in subdirectories
  • move the update logic inside the service worker
  • if the service worker receives 404s from supposedly good files, unregister itself
@Dschoordsch Dschoordsch added bug p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users p2 Needs to be addressed on a reasonable timescale and removed p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
None yet
Development

No branches or pull requests

1 participant