Upgrade Assurance new incident layout dynamic inputs for checks #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides enhancements on the Upgrade Assurance new incident layout.
arp_entry_exists
input).content_version
is checked against the latest available content version ifmin_content_version
input is not provided, otherwise it's compared with the provided version)dpmpclockdiff
andipsectunnel
to the Assurance Test new incident layout.Additionally following tests added in Assurance Test incident layout readiness check list to the selections:
String quotation marks use is also standardized to single quote (') in PAN_OS_Upgrade_Assurance.py on this PR, unless it contains another single quote or in a human message form.
Motivation and Context
Check list and input fields were causing some confusion whether they are activated when not available in the checks. Also some checks like content_version with optional inputs was not possible to activate without providing a value. This PR focuses on these changes.
How Has This Been Tested?
Tested on vm-series firewalls.
Screenshots (if appropriate)
Types of changes
Checklist