Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Assurance new incident layout dynamic inputs for checks #45

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

alperenkose
Copy link
Collaborator

@alperenkose alperenkose commented Sep 9, 2024

Description

This PR provides enhancements on the Upgrade Assurance new incident layout.

  • Test inputs for optional checks are now displayed automatically if relevant test is selected in the check list. All needed checks must be selected now in the check list (e.g. arp should be selected to display arp_entry_exists input).
  • if the checks has a required input and it's not filled in, the test is silently skipped.
  • If the check has an optional input, it's run even if the optional input is not provided. (e.g. content_version is checked against the latest available content version if min_content_version input is not provided, otherwise it's compared with the provided version)
  • Added input incident fields for dpmpclockdiff and ipsectunnel to the Assurance Test new incident layout.

Additionally following tests added in Assurance Test incident layout readiness check list to the selections:

  • active_support
  • content_version
  • session_exist
  • ipsec_tunnel
  • dp_mp_clock_diff

String quotation marks use is also standardized to single quote (') in PAN_OS_Upgrade_Assurance.py on this PR, unless it contains another single quote or in a human message form.

Motivation and Context

Check list and input fields were causing some confusion whether they are activated when not available in the checks. Also some checks like content_version with optional inputs was not possible to activate without providing a value. This PR focuses on these changes.

How Has This Been Tested?

Tested on vm-series firewalls.

Screenshots (if appropriate)

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Collaborator

@adambaumeister adambaumeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me. Great work making this so nicely integrated into the rest of the content.

@alperenkose alperenkose merged commit 7aa2422 into main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants