Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider documentation on hashicorp uses an invalid argument in panos_general_settings example #433

Open
ahmutysj3 opened this issue Apr 11, 2024 · 0 comments · May be fixed by #434
Open

provider documentation on hashicorp uses an invalid argument in panos_general_settings example #433

ahmutysj3 opened this issue Apr 11, 2024 · 0 comments · May be fixed by #434
Labels
documentation

Comments

@ahmutysj3
Copy link

Documentation link

https://registry.terraform.io/providers/PaloAltoNetworks/panos/latest/docs/resources/general_settings

Describe the problem

The example used in the provider documentation for the panos_general_settings resource uses the argument ntp_primary but the correct attribute (listed later on in the argument references) is ntp_primary_address

  • this is the current example:
resource "panos_general_settings" "example" {
    hostname = "ngfw220"
    dns_primary = "10.5.1.10"
    ntp_primary = "10.5.1.10"
    ntp_primary_auth_type = "none"

    lifecycle {
        create_before_destroy = true
    }
}

Suggested fix

update the example to this

resource "panos_general_settings" "example" {
    hostname = "ngfw220"
    dns_primary = "10.5.1.10"
    ntp_primary_address = "10.5.1.10"
    ntp_primary_auth_type = "none"

    lifecycle {
        create_before_destroy = true
    }
}
@ntwrkguru ntwrkguru linked a pull request Apr 11, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update general_settings.md PaloAltoNetworks/terraform-provider-panos
1 participant
@ahmutysj3