Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise code structure #23

Open
Palmr opened this issue Dec 9, 2018 · 0 comments
Open

Reorganise code structure #23

Palmr opened this issue Dec 9, 2018 · 0 comments
Assignees
Milestone

Comments

@Palmr
Copy link
Owner

Palmr commented Dec 9, 2018

Currently almost everything is public, which isn't great.

The only way to parse your own byte array requires calling the parsing code yourself and dealing with the result from nom, which leaks parsing implementation details outside of the crate.

There should probably be some more top level functions in lib for parsing from paths, jars, byte arrays etc.
Structs for the public data types should be together rather than scattered about.

Parsers should be together and non-public.

@Palmr Palmr added this to the 0.4.0 milestone Dec 9, 2018
@Palmr Palmr self-assigned this Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant