You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Without it being immediately obvious that Pulse <: AbstractMatrix, array concatenation behavior can be a little confusing. Consider the following which could be used to generate a CPMG pulse sequence:
I suggest specifying the expected behavior of hcat, vcat, hvcat, and the various array concatenation shorthands ([a b], [a,b], [a b; c d]) in documentation and perhaps writing some simple tests in test/runtests.jl.
The text was updated successfully, but these errors were encountered:
Without it being immediately obvious that
Pulse <: AbstractMatrix
, array concatenation behavior can be a little confusing. Consider the following which could be used to generate a CPMG pulse sequence:This gives:
If you instead replace
[Idle*(2*ndelay), Ypi]
withvcat(Idle*(2*ndelay), Ypi)
:I suggest specifying the expected behavior of
hcat
,vcat
,hvcat
, and the various array concatenation shorthands ([a b]
,[a,b]
,[a b; c d]
) in documentation and perhaps writing some simple tests intest/runtests.jl
.The text was updated successfully, but these errors were encountered: