Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: deprecated update_mode argument is still being used and will override update_on #167

Closed
gregd33 opened this issue Dec 6, 2022 · 1 comment · May be fixed by #171
Closed

Bug: deprecated update_mode argument is still being used and will override update_on #167

gregd33 opened this issue Dec 6, 2022 · 1 comment · May be fixed by #171

Comments

@gregd33
Copy link

gregd33 commented Dec 6, 2022 •
edited
Loading

So update_on is the parameter we are supposed to use. It is optional and set to [] so that the grid never updates.

update_mode is deprecated and optional but the default is GridUpdateMode.MODEL_CHANGED which is equivalent to VALUE_CHANGED | SELECTION_CHANGED | FILTERING_CHANGED | SORTING_CHANGED.

Since update_mode is still parsed, it will then set update_on=[ "cellValueChanged","selectionChanged","filterChanged","sortChanged"] which is not expected and I suspect unintended since update_on=[] by default. Even if you specify update_on with custom values, these will be added.

I think that update_mode should be set to None by default so that the default behaviour is the same as update_on. Then users can use either.

As a workaround for now, ensure that both update_on and update_mode reflect the same behaviour.
@gregd33 gregd33 mentioned this issue Dec 13, 2022
Closed
gregd33 added a commit to gregd33/streamlit-aggrid that referenced this issue Dec 13, 2022
@gregd33
Default update_mode to GridUpdateMode.NO_UPDATE
206504f 
Fixes PablocFonseca#167
This was referenced Dec 13, 2022
Closed
Open
@lomnes-atlast-food
Copy link

@gregd33 Thank you so much for posting this issue and understanding what was happening. This was a very frustrating behavior in my application and it wasn't apparent to me that it was being caused by the streamlit-aggrid components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PablocFonseca @gregd33 @lomnes-atlast-food