camera_manager: mavlink update #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update requires to set the camera_device_id in this case signalling that it is a MAVLink camera with its own MAVLink component ID.
I don't think it makes much sense to do the SITL tests here as it: - Introduces circular dependencies such mavlink. - Getting all the depdendencies is convoluted and will get out of sync with master. Eventually we anyway have to run these tests when updating the Gazebo submodul in PX4, so this is just slowing everything down with little benefit.
|
No idea what macOS is trying to do there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update requires to set the camera_device_id in this case signalling that it is a MAVLink camera with its own MAVLink component ID.