Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize maximum relative air velocity for generating thrust on the motors #1045

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Parameterize maximum relative air velocity for generating thrust on the motors #1045

merged 2 commits into from
Jun 17, 2024

Conversation

Jaeyoung-Lim
Copy link
Member

Problem Description
This PR parameterizes the maximum air relative velocity that the motor model generates, which was defined as 25m/s previously.

@Jaeyoung-Lim Jaeyoung-Lim requested a review from sfuhrer June 15, 2024 05:10
sfuhrer
sfuhrer approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you, that helps in customize the max airspeed for some models, such that they can be made more realistic (plus we can simulate flying in 20m/s+ winds).

@sfuhrer sfuhrer merged commit 7dc8042 into main Jun 17, 2024
4 of 5 checks passed
@sfuhrer sfuhrer deleted the pr-max-velocity branch June 17, 2024 08:55
@sfuhrer sfuhrer mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfuhrer sfuhrer sfuhrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaeyoung-Lim @sfuhrer