Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems testing #252

Closed
inavarretej opened this issue Oct 9, 2024 · 2 comments
Closed

Problems testing #252

inavarretej opened this issue Oct 9, 2024 · 2 comments

Comments

@inavarretej
Copy link

Hi everyone!
I came across this code and it seems very useful to what I'm doing right now so I would very much like to try. I'm working on a Windows machine with Julia 1.10 installed via Windows Store, and I installed the package using the instructions on your readme. Until there, everything is fine. The issue starts when I try to test the package via

using JustRelax
julia> ]
  pkg> test JustRelax

it goes well at the beginning

     Testing Running tests...
Testing package JustRelax.jl
Test Summary: | Pass  Total  Time
Traits        |   25     25  1.6s
Test Summary: | Pass  Total  Time
2D allocators |   44     44  0.0s
Test Summary:   | Pass  Total  Time
2D Displacement |    2      2  1.7s
Test Summary: | Pass  Total  Time
3D allocators |   53     53  0.0s
Test Summary:   | Pass  Total  Time
3D Displacement |    2      2  1.9s
Test Summary:    | Pass  Total  Time
Type conversions |    8      8  0.1s
Test Summary: | Pass  Total  Time
Type copy     |    8      8  0.2s

and then the problem arises:

Running tests from C:\Users\Usuario\.julia\packages\JustRelax\1nWan\test\test_Blankenbach.jl
Blankenbach 2D: Error During Test at C:\Users\Usuario\.julia\packages\JustRelax\1nWan\test\test_Blankenbach.jl:301
  Got exception outside of a @test
  UndefVarError: `phase_ratios_center!` not defined
  Stacktrace:
   [1] main2D(igg::IGG{Int64, MPI.Comm}; ar::Int64, nx::Int64, ny::Int64, nit::Int64)
     @ Main C:\Users\Usuario\.julia\packages\JustRelax\1nWan\test\test_Blankenbach.jl:116
   [2] macro expansion
     @ C:\Users\Usuario\.julia\packages\JustRelax\1nWan\test\test_Blankenbach.jl:312 [inlined]
   [3] macro expansion
     @ C:\Users\Usuario\.julia\packages\Suppressor\cKnGx\src\Suppressor.jl:22 [inlined]
   [4] macro expansion
     @ C:\Users\Usuario\.julia\packages\JustRelax\1nWan\test\test_Blankenbach.jl:302 [inlined]
   [5] macro expansion
     @ C:\Users\Usuario\.julia\juliaup\julia-1.10.5+0.x64.w64.mingw32\share\julia\stdlib\v1.10\Test\src\Test.jl:1577 [inlined]
   [6] top-level scope
     @ C:\Users\Usuario\.julia\packages\JustRelax\1nWan\test\test_Blankenbach.jl:302
   [7] include(mod::Module, _path::String)
     @ Base .\Base.jl:495
   [8] exec_options(opts::Base.JLOptions)
     @ Base .\client.jl:318
   [9] _start()
     @ Base .\client.jl:552
Test Summary:  | Error  Total   Time
Blankenbach 2D |     1      1  15.8s
ERROR: LoadError: Some tests did not pass: 0 passed, 0 failed, 1 errored, 0 broken.
in expression starting at C:\Users\Usuario\.julia\packages\JustRelax\1nWan\test\test_Blankenbach.jl:301

This message appears in every "major script" that needs to use the phase_ratio_center! function. Any help?

Thanks in advance

@aelligp
Copy link
Collaborator

aelligp commented Oct 9, 2024

Hi
Thanks for reaching out. I assume that you did:

julia> ] add JustRelax
(@1.10) pkg> test JustRelax

We are currently in the process of updating the miniapps and the tests according to the latest changes in one dependency package (JustPIC.jl). The phase_ratios have been moved there and the code has been removed from JustRelax. A patch release will soon follow (in the coming days to weeks).
What if you clone the main branch with:

julia> ] add JustRelax#main
(@1.10) pkg> test JustRelax

Does it work?

@inavarretej
Copy link
Author

I tried what you said and now it passed them all. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants