From d02955df91cc4a23f0f5c538d3a479bbc38f7e80 Mon Sep 17 00:00:00 2001
From: albert-de-montserrat <albert.de.montserrat@gmail.com>
Date: Sun, 17 Dec 2023 12:35:59 +0100
Subject: [PATCH] fix sher hesting kernel

---
 src/thermal_diffusion/Shearheating.jl | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/thermal_diffusion/Shearheating.jl b/src/thermal_diffusion/Shearheating.jl
index a59fc7c3..4df7d5dc 100644
--- a/src/thermal_diffusion/Shearheating.jl
+++ b/src/thermal_diffusion/Shearheating.jl
@@ -1,13 +1,20 @@
 @parallel_indices (I...) function compute_SH!(
-    H, τ, τII, τ_old, τII_old, ε, phase_ratios, rheology, dt
-)
+    SH, τ::NTuple{N, T}, τ_old::NTuple{N, T}, ε::NTuple{N, T}, rheology, dt
+) where {N, T}
+    _Gdt = inv(fn_ratio(get_G, rheology) * dt)
+    τij, τij_o, εij = JustRelax.cache_tensors(τ, τ_old, ε, I...)
+    εij_el = @. 0.5 * ((τij - τij_o) * _Gdt)
+    SH[I...] = compute_shearheating(rheology, τij, εij, εij_el)
+    return nothing
+end
+
+@parallel_indices (I...) function compute_SH!(
+    SH, τ::NTuple{N, T}, τ_old::NTuple{N, T}, ε::NTuple{N, T}, phase_ratios::CellArray, rheology, dt
+) where {N, T}
     phase = @inbounds phase_ratios[I...]
     _Gdt = inv(fn_ratio(get_G, rheology, phase) * dt)
     τij, τij_o, εij = JustRelax.cache_tensors(τ, τ_old, ε, I...)
-    τII[I...] = τII_ij = second_invariant(τij...)
-    τII_old[I...] = τII_ij_old = second_invariant(τij_o...)
-
-    εij_el = 0.5 * ((τII_ij - τII_ij_old) * _Gdt)
-    H[I...] = H_s = compute_shearheating(rheology, phase, τij, εij, εij_el)
+    εij_el = @. 0.5 * ((τij - τij_o) * _Gdt)
+    SH[I...] = compute_shearheating(rheology, phase, τij, εij, εij_el)
     return nothing
-end
+end
\ No newline at end of file