-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the difference between "filename" and "name_file"? #1
Comments
Hi there!! @Androidismyhobby Thank you for using my code! (It was part of my bachelor thesis last year) Just out of curiosity, what are you going to use it for? :D if your file to compute is ´please_please_me.wav´. Then, filename='please_please_me.wav' and name_file='please_please_me´. filename is the name of the file to be processed. And name_file is the name of the files that are generated to reduce computational cost. The reality is that this code was part of a larger distributed system and namefile was not the same as filename. But you are right that the naming doesn't help to understand. I can change it to in_file, out_file hahahaha Have you installed the vamp plugins? (to make nnls work) Have you read the paper? Thank you so much! |
Hi, @PRamoneda , Again: Great library and really a stroke of luck for me. And thanks again for the explanation :-) |
Hi, @Androidismyhobby Thanks for your kind words :) My background is also in computer science and music (piano performance). Currently, I am studying this master: https://www.upf.edu/web/smc. There are a lot of opportunities in this field. I also recommend you this library if you are interested in building models from data: https://github.com/mir-dataset-loaders/mirdata (I am collaborating in the development too xd) What university are you from? |
Hi, @PRamoneda , Thank you very much for the tip from your library. I will definitely take a look at it. Sounds very exciting and is exactly my "taste" ;-) Can I ask you one more thing about using your HCDF library? I'm sorry, I hope I don't annoy you with this:
Did I make any mistake with the input? As I said, I'm still trying a bit and I'm not very experienced with such modules so I hope I haven't made some stupid mistake ;-) |
I am always asking to everybody! Don't worry! Ok, try to download other time the library! I have removed some little problems I generated when I extracted this part of code from the whole system. if I execute this code: if __name__ == '__main__':
onset, hcdf, winows_size = harmonic_change('./audio_files/07_-_Please_Please_Me.wav',
'07_-_Please_Please_Me',
chroma='stft-44100-2048-4',
hpss=True,
tonal_model='TIV2',
blur='full',
sigma=17,
distance='euclidean')
print("chord changes", onset) the screen output is:
|
Perfect. It works. Thank you very much for your efforts and your support. Thank you very much |
Is there a difference between "filename" and "name_file"? For example, if I want to use
get_harmonic_change(filename: str, name_file: str, hpss: bool = False, tonal_model: str = 'TIV2', chroma: str = 'cqt', blur: str = 'full', sigma: int = 11, log_compresion: str = 'none', dist: str = 'euclidean')
What is the "name_fiele" here?
There is an explanation, but I didn't quite understand it. Can anyone explain this to me?
Thanks in advance
The text was updated successfully, but these errors were encountered: