Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-order CI builds #450

Open
farski opened this issue Nov 2, 2020 · 1 comment
Open

Out-of-order CI builds #450

farski opened this issue Nov 2, 2020 · 1 comment
Labels

Comments

@farski
Copy link
Member

farski commented Nov 2, 2020

It's possible for two builds of the default (main) branch of a repo to be running at the same time, and have the older build (i.e., older code) finish second, which means the newer code artifact (e.g., Docker image) would be replaced by an artifact resulting from older code. In other words, to CD, the older code would look newer, and get deployed instead.

@farski farski added the low label Jan 31, 2022
@farski
Copy link
Member Author

farski commented Aug 10, 2023

I added a note to the readme about this.

The solution to this would be something like:
Right before post_build.sh publishes something to ECR or S3, get a list of the recent SHAs from GitHub, and look up tags/objects for each. Find the ones that exist, and then look to see if a tag/object exists for a commit that is newer than the SHA of the current build exists. If so, pushing the new image/object could be skipped.

@farski farski modified the milestone: Sprint Zion Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant