Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RegSet to be able to have 128 registers / Define all FP and V registers #80

Open
gut opened this issue Sep 30, 2015 · 4 comments
Open

Improve RegSet to be able to have 128 registers / Define all FP and V registers #80

gut opened this issue Sep 30, 2015 · 4 comments
Labels
enhancement task

Comments

@gut
Copy link

gut commented Sep 30, 2015

Currently there is the limitation of indexing only up to 64 registers in HHVm. If we improve it to 128 registers (with #ifdef's), then we could add the rest of the Floating Point and Vector registers.
@gut gut added this to the ML3 milestone Nov 12, 2015
@gut gut mentioned this issue Nov 24, 2015
Open
@gut
Copy link
Author

gut commented Jan 29, 2016

Max Wang already implemented this, now we have to change our settings to make use of it.
See commit facebook@cb93af7

@gut
Copy link
Author

gut commented Feb 2, 2016

Related task: #11

@racardoso
Copy link

I think we can close this issue.

@gut
Copy link
Author

gut commented Jun 8, 2016

I don't think so. We still need to define more registers on our architecture:
https://github.com/PPC64/hhvm/blob/next/hphp/ppc64-asm/asm-ppc64.h#L396

@gut gut removed this from the ML3 milestone Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gut @racardoso