-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11 quick tests are failing when compiling with gcc 5.4.1 #166
Comments
that's odd those tests fails on gcc 5.4 or bellow if you remove r30 from clobber list. I test it here on gcc 6 and 5.4 and works. I don't have 5.4.1 anymore here. Please do a quick test try add r30 back here https://github.com/PPC64/hhvm/blob/next/hphp/util/portability.h#L192 |
I cannot compile it with gcc 5.4.1 if I include r30 in the clobber list. I'll compile with gcc 6 to check if the tests are failing as well. PS: I'm on Ubuntu 16.10 |
I cannot compile with gcc6: hhvm/third-party/re2/src/re2/dfa.cc:95:10: error: unknown array size in delete struct State { ^~~~~ |
You must follow this guide https://github.com/PPC64/hhvm/wiki/Install-on-Ubuntu-system-16.10-(Experimental) |
Followed the instructions (but I have Boost 1.58 installed) and managed to compile. Still having 11 errors: 11 tests failed (╯°□°)╯︵ ┻━┻ See the diffs: cat hphp/test/quick/constructor_throw.php.diff cat hphp/test/quick/fb_intercept.php.diff cat hphp/test/quick/intercept2.php.diff cat hphp/test/quick/profile/Setprofile.php.diff cat hphp/test/quick/profile/Setprofile_async.php.diff cat hphp/test/quick/profile/Setprofile_generic.php.diff cat hphp/test/quick/profile/setprofile-this.php.diff cat hphp/test/quick/profile/setprofile_throw.php.diff cat hphp/test/quick/surprise_throw.php.diff cat hphp/test/quick/xenon/xenon.php.diff cat hphp/test/quick/xenon/xenon_init.php.diff |
That's make no sense to me I tested it here with gcc 6 and Ubuntu 16.10 and have no failures. I will check this. |
Well find out that we have 11 tests failing. But I don't know if it's a clobber problem since I tested it before. Anyway I will fix it as soon I come back. |
The text was updated successfully, but these errors were encountered: