Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 quick tests are failing when compiling with gcc 5.4.1 #166

Open
brunoalr opened this issue Jan 13, 2017 · 7 comments
Open

11 quick tests are failing when compiling with gcc 5.4.1 #166

brunoalr opened this issue Jan 13, 2017 · 7 comments
Labels

Comments

@brunoalr
Copy link

brunoalr commented Jan 13, 2017

11 tests failed
(╯°□°)╯︵ ┻━┻

�[0;33mSee the diffs:�[0m
cat hphp/test/quick/constructor_throw.php.diff
cat hphp/test/quick/fb_intercept.php.diff
cat hphp/test/quick/intercept2.php.diff
cat hphp/test/quick/profile/Setprofile.php.diff
cat hphp/test/quick/profile/Setprofile_async.php.diff
cat hphp/test/quick/profile/Setprofile_generic.php.diff
cat hphp/test/quick/profile/setprofile-this.php.diff
cat hphp/test/quick/profile/setprofile_throw.php.diff
cat hphp/test/quick/surprise_throw.php.diff
cat hphp/test/quick/xenon/xenon.php.diff
cat hphp/test/quick/xenon/xenon_init.php.diff
@brunoalr brunoalr added the bug label Jan 13, 2017
@racardoso
Copy link

that's odd those tests fails on gcc 5.4 or bellow if you remove r30 from clobber list. I test it here on gcc 6 and 5.4 and works. I don't have 5.4.1 anymore here. Please do a quick test try add r30 back here https://github.com/PPC64/hhvm/blob/next/hphp/util/portability.h#L192

@brunoalr
Copy link
Author

I cannot compile it with gcc 5.4.1 if I include r30 in the clobber list. I'll compile with gcc 6 to check if the tests are failing as well.

PS: I'm on Ubuntu 16.10

@brunoalr
Copy link
Author

I cannot compile with gcc6:

hhvm/third-party/re2/src/re2/dfa.cc:95:10: error: unknown array size in delete
   struct State {
          ^~~~~

@racardoso
Copy link

@brunoalr
Copy link
Author

Followed the instructions (but I have Boost 1.58 installed) and managed to compile. Still having 11 errors:

11 tests failed
(╯°□°)╯︵ ┻━┻

See the diffs:
cat hphp/test/quick/constructor_throw.php.diff
cat hphp/test/quick/fb_intercept.php.diff
cat hphp/test/quick/intercept2.php.diff
cat hphp/test/quick/profile/Setprofile.php.diff
cat hphp/test/quick/profile/Setprofile_async.php.diff
cat hphp/test/quick/profile/Setprofile_generic.php.diff
cat hphp/test/quick/profile/setprofile-this.php.diff
cat hphp/test/quick/profile/setprofile_throw.php.diff
cat hphp/test/quick/surprise_throw.php.diff
cat hphp/test/quick/xenon/xenon.php.diff
cat hphp/test/quick/xenon/xenon_init.php.diff

@racardoso
Copy link

That's make no sense to me I tested it here with gcc 6 and Ubuntu 16.10 and have no failures. I will check this.

@racardoso
Copy link

Well find out that we have 11 tests failing. But I don't know if it's a clobber problem since I tested it before. Anyway I will fix it as soon I come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants