Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined binaries in flow: ('stripped_He_Core_He_burning', 'H-rich_Core_He_burning', 'contact', None) #459

Open
mkruckow opened this issue Nov 28, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@mkruckow
Copy link
Collaborator

When doing some tests for v2.0pre1, I have see in a NN run a case of

Traceback (most recent call last):
  File "/home/users/k/kruckow/POSYDON/posydon/popsyn/binarypopulation.py", line 325, in _safe_evolve
    binary.evolve()
  File "/home/users/k/kruckow/POSYDON/posydon/binary_evol/binarystar.py", line 219, in evolve
    self.run_step()
  File "/home/users/k/kruckow/POSYDON/posydon/binary_evol/binarystar.py", line 238, in run_step
    raise ValueError("Undefined next step given stars/binary states {}.".format(total_state))
ValueError: Undefined next step given stars/binary states ('stripped_He_Core_He_burning', 'H-rich_Core_He_burning', 'contact', None).

Failed Binary Initial Conditions:
S1 mass: 51.50296903439762
S2 mass: 49.40027877048686
S1 state: H-rich_Core_H_burning
S2 state: H-rich_Core_H_burning
orbital period: 67.68449970635564
eccentricity: 0.0
binary state: detached
binary event: detached
S1 natal kick array: [None None None None]
S2 natal kick array: [None None None None]

Shouldn't a contact have a CE as event? Is it may related to issue #369 ?

@mkruckow mkruckow added bug Something isn't working help wanted Extra attention is needed question Further information is requested labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant