Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out doublicated functions and variables #442

Open
mkruckow opened this issue Nov 21, 2024 · 0 comments
Open

Clean out doublicated functions and variables #442

mkruckow opened this issue Nov 21, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers v2 feature should go in v2

Comments

@mkruckow
Copy link
Collaborator

We have different functions and variables which have duplicates. We should clean that up to always use one version.
Here some examples

  • posydon.utils.gridutils.kepler3_a vs. posydon.utils.common_functions.orbital_separation_from_period
  • posydon.utils.gridutils.T_merger_P vs. posydon.utils.common_functions.inspiral_timescale_from_orbital_period
  • posydon.utils.gridutils.T_merger_a vs. posydon.utils.common_functions.inspiral_timescale_from_separation
  • variables are often hard coded in functions instead of imported from where they are defined, this happens often in step_* vs. flow_chart
@mkruckow mkruckow added enhancement New feature or request good first issue Good for newcomers v2 feature should go in v2 labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers v2 feature should go in v2
Projects
None yet
Development

No branches or pull requests

1 participant