Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect assignment of "initial_RLOF" state #412

Open
celiotine opened this issue Oct 15, 2024 · 0 comments
Open

incorrect assignment of "initial_RLOF" state #412

celiotine opened this issue Oct 15, 2024 · 0 comments
Assignees
Labels
help wanted Extra attention is needed v2 feature should go in v2

Comments

@celiotine
Copy link
Contributor

Some binaries are being assigned the "initial_RLOF" state late in their evolution, which is causing them to complete their evolution incorrectly. Here is an example (run with PR #404):

Screen Shot 2024-10-15 at 10 37 42 AM

Here are the conditions for re-running this binary with the file /projects/b1119/cliotine/dev_general/debugging/params.ini:

sim_kwargs_IF = simprop_kwargs_from_ini(ini_filepath_IF)
sim_prop_IF = SimulationProperties(**sim_kwargs_IF)
sim_prop_IF.load_steps(verbose=True)

star_1 = SingleStar(**{'mass': 9.207256, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [91.182965, 0.776432, 1.484747, 4.567527]})
star_2 = SingleStar(**{'mass': 9.093124, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0,  'state': 'detached',  'event': 'ZAMS', 
                        'orbital_period': 16.34274,'eccentricity': 0.0}, properties = sim_prop_IF)
binary_IF.evolve()

Per discussion with @mkruckow and @maxbriel , this seems like an issue with the interpolator, and it is possible we may need to add additional constraints when inferring the star state.

@celiotine celiotine added the bug Something isn't working label Oct 15, 2024
@celiotine celiotine self-assigned this Nov 7, 2024
@celiotine celiotine added help wanted Extra attention is needed v2 feature should go in v2 and removed bug Something isn't working labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed v2 feature should go in v2
Projects
None yet
Development

No branches or pull requests

1 participant