Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scipy interp1d now deprecated #408

Open
elizabethteng opened this issue Oct 7, 2024 · 2 comments
Open

Scipy interp1d now deprecated #408

elizabethteng opened this issue Oct 7, 2024 · 2 comments
Assignees
@celiotine
Labels
bug Something isn't working v2 feature should go in v2

Comments

@elizabethteng
Copy link
Contributor

interp1d is a legacy class and will no longer be updated. Scipy recommends switching to numpy.interp for basic linear interpolation.
@elizabethteng elizabethteng added bug Something isn't working good first issue Good for newcomers labels Oct 7, 2024
@elizabethteng
Copy link
Contributor Author

This is causing issues for the following import statement:
from posydon.utils.common_functions import check_state_of_star_history_array

@mkruckow mkruckow removed the good first issue Good for newcomers label Oct 7, 2024
@celiotine celiotine self-assigned this Nov 12, 2024
@celiotine celiotine mentioned this issue Nov 12, 2024
Open
@celiotine
Copy link
Contributor

I opened PR #433 to address this issue.

@celiotine celiotine added the v2 feature should go in v2 label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@celiotine celiotine

Labels
bug Something isn't working v2 feature should go in v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@celiotine @elizabethteng @mkruckow