PR v1.4.3 with fixes? Or migrate to the v2 RC?

[almightynassar]

Hi,

Just wondering what the status is.... the master branch uses preg_replace() instead of str_replace() that 1.4.2 has. I'd like that fix in a 1.4 version of the branch, because I'm unsure how to migrate to the new 2.0 branch (it seems to use JWTManager instead of JWTAuth, so I am assuming there are a few other changes under the hood).

So yeah, should I wait for some migration doco and the RC to come out, or should I make a PR request for a 1.4.3 version with some fixes?

[mfn]

because I'm unsure how to migrate to the new 2.0 branch

What are the specific issues/error/exception you have?

It's almost 2 weeks since the RC so I think we should push out the final 2.0 soon.

[almightynassar]

The one I'm noticing now is the preg_replace() one, since it won't overwrite an empty key in my config that I have as a default entry when I deploy.

So not a big issue, just curious on what the plans are

[eschricker]

Just wondering what the status is.... the master branch uses preg_replace() instead of str_replace() that 1.4.2 has. I'd like that fix in a 1.4 version of the branch, because I'm unsure how to migrate to the new 2.0 branch (it seems to use JWTManager instead of JWTAuth, so I am assuming there are a few other changes under the hood).

Our version 2 is not basing on the branch 2.0, which was created by tymon.

The changes between 1.4.2 and 2.0.0-RC1 can be seen here: 1.4.2...HEAD

[mfn]

FTR, I've released 2.0.0 now!